Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): correctly track scope #10300

Merged
merged 2 commits into from
Oct 1, 2022
Merged

fix(ssr): correctly track scope #10300

merged 2 commits into from
Oct 1, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 30, 2022

Description

Fix #10289

Update scope tracking to consider classes, functions, if/else-if/else blocks as scope boundaries, rather than just functions.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr labels Sep 30, 2022
@patak-dev patak-dev merged commit a60529f into main Oct 1, 2022
@patak-dev patak-dev deleted the ssr-fix-scope-tracking branch October 1, 2022 04:47
@patak-dev
Copy link
Member

(@antfu FYI, in case you're already playing with the SSR transform transpiler)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed transformation due to bad scope analysis
2 participants